build: Add Travis Job to Lint Go Code #15372

[danmelton]

build: removes misspell from test option, implements generalized linter job system for travis and ci [finishes #15372]

This PR adds a generalized lint job that can be ran on the command line, and extended with additional linters:

go run build/ci.go lint

It also removes the misspell option from the test run (it's implementation was problematic and commented out). If this approach is acceptable, we can add misspell as an optional linter in the new doLint function

Lastly, there is a new travis job that runs the build/ci.go lint task.

[GitCop]

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

• Commit: f4f5ab92e4618f01fcb54e9942e852b588a6b231
• Your commit message body contains a line that is longer than 80 characters
• Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

---

This message was auto-generated by https://gitcop.com

[karalabe]

Ah, sweet, this is very nice, thank you! I'll push a tiny fixup for some irrelevant little stuff and will merge. Thanks!

Btw, I'll disable the dead code checker, since it is failing travis currently (I knew it would) and we can then open subsequent tickets to fix certain linter issues and then at the same time enable the relevant linter.

[fjl]

I like this a lot, but we can't merge it because linters report errors and fail CI. But I have a suggestion: let's add the lint subcommand without any active linters, then add them one by one.

[fjl]

Please fix whitespace

[danmelton]

glad to help!

[karalabe]

Thanks! :)