cmd, dashboard: dashboard using React, Material-UI, Recharts

[kurkomisi]

Work in progress dashboard prototype.
Description in the README file.

[karalabe]

Please fix all your files so they have a newline at the end.

[karalabe]

Also skip the bundle.js, since it's an intermediate build step between source jsx and the final assets.go

[karalabe]

Pls drop "default"

[karalabe]

No need for double title.

[karalabe]

No need for user docs, that may or may not be done in some global documentation.

[karalabe]

--dashboard should auto-enable --metrics.

[karalabe]

Unless really really often needed, please just inline the actual code instead of the defaultZero (avoids problems with non-int types).

[karalabe]

Lets use the following order:

• Home
• Chain
• Transactions
• Network
• System
• Logs

[karalabe]

Please add the LGPL3 copyright headers to all (non-generated) files

// Copyright 2017 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The go-ethereum library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

[karalabe]

Use theme ;)

[karalabe]

Pls align these a bit "nicer" ;P

[karalabe]

If possible, please align struct initializers. An automated tool is even better, a CI linter is possibly the best.

[kurkomisi]

This rule will handle it
https://eslint.org/docs/rules/key-spacing

[karalabe]

new WebSocket(((window.location.protocol === "https:") ? "wss://" : "ws://") + window.location.host + "/api");

[karalabe]

Perhas call metrics -> history.

[karalabe]

Please retain data arrays here and only convert later when actually rendering. Also I don't think there's a need to have specialized memory and traffic datakeys, we can just use value as the key (my 2c, open for debate).

[karalabe]

Align pls.

[karalabe]

No :P Pls expand

[karalabe]

Pls use TRAFFIC_SAMPLE_LIMIT for the traffic if you defined it.

[karalabe]

Also a bit more flexible would be to do

while (memory.length >= MEMORY_SAMPLE_LIMIT) {
    memory.shift();
}

[karalabe]

• while
• const
• 4096

[karalabe]

if

[karalabe]

Please use theme colors everywhere instead of custom ones so they can be easily swapped out with the theme.

[karalabe]

load = event => {
    event.preventDefault();
    this.props.changeContent(event.target.id);
};

[karalabe]

id={tag.id} onClick={this.load} ...

[karalabe]

Before go-bindata, I'd suggest also regenerating the bundle.js to a dev doesn't need to remembed the "correct" workflow, rather just use go generate and be done with it.

[karalabe]

Pls drop dead code.

[karalabe]

Pls drop dead code.

[karalabe]

Lets rename this to chartEntry

[karalabe]

Lets rename metricSamples to charts, containing []chartEntry

[karalabe]

Please inline this and group by chart type, not by operation.

[karalabe]

filepath.Join :)

[karalabe]

new(charts)

[karalabe]

Perhaps rename Metrics to Charts

[karalabe]

quit is usually the thing used in the go-ethereum codebase

[karalabe]

Don't ignore errors, log at least, preferrably store and return at the end of the function.

[karalabe]

webapp -> blob.

[karalabe]

file -> blob

[karalabe]

Pls add path to the error log.

[karalabe]

done := make(chan struct{})

[karalabe]

close(done)

[karalabe]

You don't need a pointer, map is already a lightweight wrapper.

[karalabe]

Also please convert the map[string]interface{} to a proper type with typed fields and json tags.

[karalabe]

(drop)

[karalabe]

Doc sendToAll

[karalabe]

LGTM