Skip to content

les, core/bloombits: trivial post-LES/2 fixes#15391

Merged
karalabe merged 2 commits into
ethereum:masterfrom
zsfelfoldi:les-topic-fix
Oct 27, 2017
Merged

les, core/bloombits: trivial post-LES/2 fixes#15391
karalabe merged 2 commits into
ethereum:masterfrom
zsfelfoldi:les-topic-fix

Conversation

@zsfelfoldi
Copy link
Copy Markdown
Contributor

No description provided.

@zsfelfoldi zsfelfoldi changed the title les: fix topic ID les, core/bloombits: trivial post-LES/2 fixes Oct 27, 2017
Comment thread core/bloombits/matcher.go Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this:

if err := s.err.Load(); err != nil {
  return err.(error)
}
return nil	

Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 8d434f6 into ethereum:master Oct 27, 2017
@karalabe karalabe added this to the 1.7.3 milestone Oct 27, 2017
vincentserpoul pushed a commit to vincentserpoul/go-ethereum that referenced this pull request Nov 22, 2017
* les: fix topic ID

* core/bloombits: fix interface conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants