Skip to content

internal/ethapi: Add method getBalanceFromJs for work with address as bytes#15297

Merged
karalabe merged 4 commits into
ethereum:masterfrom
pixelplex-dev-team:master
Nov 18, 2017
Merged

internal/ethapi: Add method getBalanceFromJs for work with address as bytes#15297
karalabe merged 4 commits into
ethereum:masterfrom
pixelplex-dev-team:master

Conversation

@pixelplex
Copy link
Copy Markdown
Contributor

@GitCop
Copy link
Copy Markdown

GitCop commented Oct 14, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 58bc91a
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@pixelplex pixelplex changed the title Add method getBalanceFromJs for work with address as bytes internal/ethapi: Add method getBalanceFromJs for work with address as bytes Oct 14, 2017
@karalabe karalabe requested a review from Arachnid October 17, 2017 20:22
@karalabe
Copy link
Copy Markdown
Member

Seems to me that the single getBalance method shout "just work (TM)". Unsure where the type information gets lost between Go -> Js -> Go conversion. Perhaps getBalance should have been []byte all along? @Arachnid ?

@GitCop
Copy link
Copy Markdown

GitCop commented Nov 11, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 58bc91a
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@Arachnid
Copy link
Copy Markdown
Contributor

See my update to the referenced issue.

@Arachnid
Copy link
Copy Markdown
Contributor

All the methods that take common.Address need to be changed to take []byte and call common.BytesToAddress. No new methods are needed. Can you update your PR?

@viktor32
Copy link
Copy Markdown

Oh sure. I will do in the near future

@GitCop
Copy link
Copy Markdown

GitCop commented Nov 13, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 58bc91a

  • Commits must be prefixed with the package(s) they modify

  • Commit: 9bebb9a

  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@pixelplex
Copy link
Copy Markdown
Contributor Author

@Arachnid I corrected what you asked for
Please take a look

Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit f5091e5 into ethereum:master Nov 18, 2017
@karalabe karalabe added this to the 1.7.3 milestone Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants