rpc: check content-type for HTTP requests#15220
Merged
Merged
Conversation
holiman
approved these changes
Sep 29, 2017
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM; but maybe we should wait until after byzantium before merging any potentially breaking changes to the API, so people can use an older version if this breaks their setups.
dherbst
reviewed
Sep 29, 2017
Contributor
There was a problem hiding this comment.
You may want to consider not reflecting untrusted user submitted data here and change the message to "invalid content type, only application/json is supported".
Member
Author
There was a problem hiding this comment.
Good point, I don't immediately see how an adversary can abuse this but there might be ways.
dylanjw
added a commit
to dylanjw/homestead-guide
that referenced
this pull request
Jan 16, 2018
geth checks for mime header: ethereum/go-ethereum#15220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that HTTP RPC requests contain the
content-typeheader withapplication/json.