core,tests: Fix #15119, don't create account in state_transition#15163
Closed
holiman wants to merge 1 commit into
Closed
core,tests: Fix #15119, don't create account in state_transition#15163holiman wants to merge 1 commit into
holiman wants to merge 1 commit into
Conversation
Contributor
|
Replaced by #16470 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #15119, and makes a few more failing tests pass. WIthout this patch, in pre-spurious dragon:
This is not a cause for concern at this point, but is an error. This is because to to-account is created early in the state transition, before the reversion-snapshot is taken.
Before we merge this PR, we should really, really think about possiblle consequences of this change.