cmd/evm, core/vm/runtime: add more support for prestate configs#15034
Closed
cdetrio wants to merge 2 commits into
Closed
cmd/evm, core/vm/runtime: add more support for prestate configs#15034cdetrio wants to merge 2 commits into
cdetrio wants to merge 2 commits into
Conversation
holiman
reviewed
Aug 24, 2017
Contributor
There was a problem hiding this comment.
This will likely throw if the sender is not in prestate (?). Would be good if it's still possible to just do evm --code 6040 run and not worry about the rest.
Contributor
There was a problem hiding this comment.
Isn't this only necessary when if ctx.GlobalBool(DumpFlag.Name) is set, which does stateDb.IntermediateRoot?
Contributor
|
@cdetrio You've marked this as work-in-progress, please update the text if you consider it to not be work-in-progress any more. |
Contributor
|
This PR is now out of date and I can't see how it is useful. Please reopen if you still want this functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-in-progress. Probably breaks the evm command if not given a prestate (todo: fallback to defaults when not given a
--prestate).