Skip to content

Fixed canary to require 2+ nonzero, not sum 2+#1502

Merged
obscuren merged 1 commit intodevelopfrom
canaryFix
Jul 20, 2015
Merged

Fixed canary to require 2+ nonzero, not sum 2+#1502
obscuren merged 1 commit intodevelopfrom
canaryFix

Conversation

@obscuren
Copy link
Contributor

No description provided.

obscuren added a commit that referenced this pull request Jul 20, 2015
Fixed canary to require 2+ nonzero, not sum 2+
@obscuren obscuren merged commit f1daed6 into develop Jul 20, 2015
@obscuren obscuren deleted the canaryFix branch July 20, 2015 23:17
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022
This log statement was being hit as part of gas estimation if using non-Celo currencies for the fees.  However, this is a normal part of gas estimation's binary search, which sets the search's bottom at 21k gas and doesn't account for intrinsic gas being higher in some cases.  As such, it should not log an error message.  An alternative solution would be to calculate the intrinsic gas taking into account the fee currency and use that as the low end of the binary search.
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request May 16, 2025
…perms

(chore): change file permissions to 755 for packaging and misc scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants