core/vm: implement metropolis static call opcode #14978
Conversation
karalabe
force-pushed
the
metropolis-staticcall
branch
from
0f5f597
to
570ae36
Compare
* Fix STATICCALL so it is able to call precompiles too * Fix write detection to use the correct value argument of CALL * Fix write protection to ignore the value in CALLCODE
karalabe
force-pushed
the
metropolis-staticcall
branch
from
570ae36
to
3df7142
Compare
| } | ||
| contract.Gas += returnGas | ||
|
|
||
| evm.interpreter.intPool.put(addr, inOffset, inSize, retOffset, retSize) |
There was a problem hiding this comment.
Instead of allocating a new bigint, and returning e.g. addr to the intpool, you could do
addr.setUint64(0 or 1)
stack.push(addr)
There was a problem hiding this comment.
Looking through the other instructions, similar tricks could be done throughout the code. Also there are a lot of stack.pop().Uint64() invocations which don't even return the big int into the pool, just silently discard it.
All in all I think it would be wiser to do a whole refactor for all the opcode and do that in a separate PR where we can review the optimization changes without metro additions in there.
There was a problem hiding this comment.
Yeah, I have one such laying around, which also uses peek instead of pop, so you just make sure that the result winds up there and everything is dandy.
Implements ethereum/EIPs#214