Skip to content

accounts/abi: Types redo#14735

Closed
VoR0220 wants to merge 3 commits into
ethereum:masterfrom
VoR0220:typesRedo
Closed

accounts/abi: Types redo#14735
VoR0220 wants to merge 3 commits into
ethereum:masterfrom
VoR0220:typesRedo

Conversation

@VoR0220
Copy link
Copy Markdown
Member

@VoR0220 VoR0220 commented Jun 30, 2017

  • this includes an intermediate better slice/array scheme (there's a better one in the next PR which will be coming in the next few hours)
  • this includes a redone type schema where most of the type is handled by reflection and the typebyte, and consequently, resolves to the reflect.Type of its kind at all points (see type tests if this statement is confusing and correct me please).
  • includes vigorous testing of the types and eliminates the ability to specifiy "uint" or "int" because that is incorrect and should evaluate to the full size in the abi (ie it's the compilers job to make sure it evaluates fully to uint256 or int256)
  • Can now create fully recursive slices/arrays of any type available in the ABI.

RJ Catalano added 3 commits June 30, 2017 11:53
Signed-off-by: RJ Catalano <rj@monax.io>
Signed-off-by: RJ Catalano <rj@monax.io>
Signed-off-by: RJ Catalano <rj@monax.io>
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Sep 10, 2017

This is contained in #14743

@fjl fjl closed this Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants