Skip to content

accounts/abi: Better Array/Slice Handling#14664

Closed
VoR0220 wants to merge 11 commits into
ethereum:masterfrom
VoR0220:BetterArrayTesting
Closed

accounts/abi: Better Array/Slice Handling#14664
VoR0220 wants to merge 11 commits into
ethereum:masterfrom
VoR0220:BetterArrayTesting

Conversation

@VoR0220
Copy link
Copy Markdown
Member

@VoR0220 VoR0220 commented Jun 20, 2017

  • Eliminates entire switch case that was not only ugly as sin, but inefficient to boot.

  • Adds a new test function that should be exclusively for handling slices and arrays.

  • changes the name of ubig_t (and type) to something a bit more useful (derefbig_t...open to suggestions on a name change).

  • todo: Add more tests for every type (might be here, might be in a later PR, depends). As it stands, it currently passes.

REQUIRES #14610

@VoR0220 VoR0220 force-pushed the BetterArrayTesting branch 4 times, most recently from 50784b8 to 50ee5a2 Compare June 26, 2017 16:22
@GitCop
Copy link
Copy Markdown

GitCop commented Jun 26, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 3f7b7ff289894e345fb78b3ed845edb52aa857a8

  • Commit subjects should be kept under 100 characters

  • Commit: 50ee5a2eb4e25b30651146140f472be94c05ff94

  • Commit subjects should be kept under 100 characters

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

2 similar comments
@GitCop
Copy link
Copy Markdown

GitCop commented Jun 27, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 3f7b7ff289894e345fb78b3ed845edb52aa857a8

  • Commit subjects should be kept under 100 characters

  • Commit: 50ee5a2eb4e25b30651146140f472be94c05ff94

  • Commit subjects should be kept under 100 characters

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

@GitCop
Copy link
Copy Markdown

GitCop commented Jun 30, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 3f7b7ff289894e345fb78b3ed845edb52aa857a8

  • Commit subjects should be kept under 100 characters

  • Commit: 50ee5a2eb4e25b30651146140f472be94c05ff94

  • Commit subjects should be kept under 100 characters

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

RJ Catalano added 10 commits June 29, 2017 22:47
accounts/abi: eliminated entire switch case for slices and made the s…
89c3bfd 
…etup easier and more intuitive.

Signed-off-by: RJ Catalano <rj@monax.io>

accounts/abi: fixup to clean this up.

Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: more extensive testing of slices and arrays for all int…
9bb7fd7 
…eger types

Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: hex-ify the tests made for this branch.
ef94e2c 
Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: need to figure out what we're doing with bytes but 2D a…
824373a 
…rrays/slices work now type creation wise.

Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: finished up type tests, now comes packing and unpacking
3a72388 
Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: current workings on packing and unpacking, trying to de…
a0083e9 
…cide how to design this

Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: begin redo
59b55e0 
Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: redo unpacking logic into nice modular pieces
d19a4cd 
Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: fixes and ridding of old tests that don't resemble what…
dd1d9d3 
… we're going for

Signed-off-by: RJ Catalano <rj@monax.io>
accounts/abi: fix up nasty rebase error
2b0b97c 
Signed-off-by: RJ Catalano <rj@monax.io>
@GitCop
Copy link
Copy Markdown

GitCop commented Jun 30, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 3f7b7ff289894e345fb78b3ed845edb52aa857a8

  • Commit subjects should be kept under 100 characters

  • Commit: 50ee5a2eb4e25b30651146140f472be94c05ff94

  • Commit subjects should be kept under 100 characters

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

accounts/abi: its alive and working
ed645a3 
Signed-off-by: RJ Catalano <rj@monax.io>
@VoR0220 VoR0220 force-pushed the BetterArrayTesting branch from d9c0b48 to ed645a3 Compare June 30, 2017 17:05
@GitCop
Copy link
Copy Markdown

GitCop commented Jun 30, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 824373a
  • Commit subjects should be kept under 100 characters

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Sep 10, 2017

This is contained in #14743

@fjl fjl closed this Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VoR0220 @GitCop @fjl