cmd/evm: add --prestate, --sender, --json flags for fuzzing by holiman · Pull Request #14476 · ethereum/go-ethereum

holiman · 2017-05-15T20:48:15Z

This is work in progress, do not merge yet.

This adds support to execute evm with a custom genesis, primarily to be able to use alloc section and config to test various evm hardfork rule implementations.

Example execution below

#cat g.json 
{
  "nonce":      "0x0000000000000000",
  "difficulty": "0x1",
  "mixhash":    "0x0000000000000000000000000000000000000000000000000000000000000000",
  "coinbase":   "0x0000000000000000000000000000000000000000",
  "timestamp":  "0x00",
  "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
  "extraData":  "0x0000000000000000000000000000000000000000000000000000000000000000",
  "gasLimit":   "0x3D0900",
  "alloc": {
    "0x2a50613a76a4c2c58d052d5ebf3b03ed3227eae9" :{ "balance": "1000000000000000000000000"}
  },
    "config": {
            "homesteadBlock": 10
    }
}

Execution with the specified genesis file, with frontier-rules, where BALANCE cost 20, and 0x2a50613a76a4c2c58d052d5ebf3b03ed3227eae9 has some ether allocated:

[~/go/src/github.com/ethereum/go-ethereum]
#make evm && build/bin/evm --debug --genesisflag g.json --code "732a50613a76a4c2c58d052d5ebf3b03ed3227eae931" run 
build/env.sh go run build/ci.go install ./cmd/evm
>>> /usr/local/go/bin/go install -ldflags -X main.gitCommit=ef7b9fb7d0cbcc2e381074f6be82e4791c41bdeb -v ./cmd/evm
github.com/ethereum/go-ethereum/cmd/evm
Done building.
Run "build/bin/evm" to start the evm.
GenesisPath: g.json
Genesi config {ChainID: <nil> Homestead: 10 DAO: <nil> DAOSupport: false EIP150: <nil> EIP155: <nil> EIP158: <nil> Engine: unknown}#### TRACE ####
PUSH20    pc=00000000 gas=9999999997 cost=3

BALANCE   pc=00000021 gas=9999999977 cost=20
00000000  0000000000000000000000002a50613a76a4c2c58d052d5ebf3b03ed3227eae9

STOP      pc=00000022 gas=9999999977 cost=0
00000000  00000000000000000000000000000000000000000000d3c21bcecceda1000000

#### LOGS ####
evm execution time: 60.482µs
heap objects:       10345
allocations:        1866256
total allocations:  1866256
GC calls:           0

0x

Execution with defaults, ( latest HF rules), where BALANCE cost 400, and 0x2a50613a76a4c2c58d052d5ebf3b03ed3227eae9 is not prefunded:

[~/go/src/github.com/ethereum/go-ethereum]
#make evm && build/bin/evm --debug --code "732a50613a76a4c2c58d052d5ebf3b03ed3227eae931" run 
build/env.sh go run build/ci.go install ./cmd/evm
>>> /usr/local/go/bin/go install -ldflags -X main.gitCommit=ef7b9fb7d0cbcc2e381074f6be82e4791c41bdeb -v ./cmd/evm
Done building.
Run "build/bin/evm" to start the evm.
#### TRACE ####
PUSH20    pc=00000000 gas=9999999997 cost=3

BALANCE   pc=00000021 gas=9999999597 cost=400
00000000  0000000000000000000000002a50613a76a4c2c58d052d5ebf3b03ed3227eae9

STOP      pc=00000022 gas=9999999597 cost=0
00000000  0000000000000000000000000000000000000000000000000000000000000000

#### LOGS ####
evm execution time: 47.425µs
heap objects:       10047
allocations:        1840664
total allocations:  1840664
GC calls:           0

0x

GitCop · 2017-05-15T21:25:50Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 5bbc233df42758971e9ebc01de44ceb4997d6f27
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

holiman · 2017-05-15T21:26:46Z

Added support for json output:

#build/bin/evm --debug --code "732a50613a76a4c2c58d052d5ebf3b03ed3227eae9316001600155" --json --genesis g.json run 2>/dev/null
{"Pc":0,"Op":115,"Gas":9999999997,"GasCost":3,"Memory":"","Stack":[],"Storage":{},"Depth":1,"Err":null}
{"Pc":21,"Op":49,"Gas":9999999977,"GasCost":20,"Memory":"","Stack":[241570141776300762653945057459344026450497366761],"Storage":{},"Depth":1,"Err":null}
{"Pc":22,"Op":96,"Gas":9999999974,"GasCost":3,"Memory":"","Stack":[1000000000000000000000000],"Storage":{},"Depth":1,"Err":null}
{"Pc":24,"Op":96,"Gas":9999999971,"GasCost":3,"Memory":"","Stack":[1000000000000000000000000,1],"Storage":{},"Depth":1,"Err":null}
{"Pc":26,"Op":85,"Gas":9999979971,"GasCost":20000,"Memory":"","Stack":[1000000000000000000000000,1,1],"Storage":{"0x0000000000000000000000000000000000000000000000000000000000000001":"0x0000000000000000000000000000000000000000000000000000000000000001"},"Depth":1,"Err":null}
{"Pc":27,"Op":0,"Gas":9999979971,"GasCost":0,"Memory":"","Stack":[1000000000000000000000000],"Storage":{"0x0000000000000000000000000000000000000000000000000000000000000001":"0x0000000000000000000000000000000000000000000000000000000000000001"},"Depth":1,"Err":null}
0x

holiman · 2017-05-19T13:11:12Z

Rebased. This is pretty good-to-go, but as I'm waiting for Parity to build something similar, I may have to modify it a bit to behave the same way as theirs. So IMO it can be merged now or later, not time-critical

obscuren · 2017-05-22T07:02:39Z

I've looked at this PR 3 times now and I've been trying to make sense of this in my head. I still can't figure out why this is needed. Can you please explain?

holiman · 2017-05-25T15:16:51Z

I've rebased it now and changed the flag name to prestate

obscuren · 2017-06-01T20:51:43Z

@holiman I think the JSON output needs to be formatted using lower camel case, not upper camel. Please add json:"gas" etc.

holiman · 2017-06-02T08:34:17Z

I've done that, I just haven't committed the most recent code yet.

obscuren · 2017-06-02T09:01:39Z

👍

holiman · 2017-06-04T18:52:03Z

I've added ability for the evm to report gas used, and show it in statdump.

…d prestate

fjl · 2017-06-06T07:30:31Z

+	Gas     math.HexOrDecimal64 `json:"gas"`
+	GasCost math.HexOrDecimal64 `json:"gasCost"`
+	Memory  string              `json:"memory"`
+	Stack   hexArray            `json:"stack"`


You can use gencodec to avoid writing the conversion.

//go:generate gencodec -type StructLogJson -field-override structLogJsonMarshaling -out gen_structlog_json.go type StructLogJson struct{ ... Stack []*big.Int } type structLogJsonMarshaling struct{ Stack []*math.HexOrDecimal256 }

This would create a MarshalJSON method that converts Stack internally.

Oh nice, thanks. I wasn't sure how to cast those kind of spells

fjl · 2017-06-06T07:35:41Z


-// captureState logs a new structured log message and pushes it out to the environment
+// NewJSONLogger returns a new JSON logger
+func NewJSONLogger(writer io.Writer) *JSONLogger {


IMHO this logger should be defined in cmd/evm.

GitCop · 2017-06-07T12:00:39Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: d47802a
Commits must be prefixed with the package(s) they modify
Commit: bfed02b
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2017-06-07T12:42:30Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: d47802a
Commits must be prefixed with the package(s) they modify
Commit: bfed02b
Commits must be prefixed with the package(s) they modify
Commit: b1f55451504b480f939c1546588847ecd4de16a9
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

…#14476)

holiman force-pushed the evmfuzz branch 2 times, most recently from 81e07ab to 252a836 Compare May 19, 2017 12:54

fjl changed the title ~~EVM custom genesis+chainconfig~~ cmd/evm: add --genesis and --json options May 24, 2017

holiman force-pushed the evmfuzz branch from 252a836 to 3cae484 Compare May 25, 2017 15:16

fjl modified the milestone: 1.6.3 May 31, 2017

karalabe modified the milestones: 1.6.4, 1.6.3 Jun 1, 2017

holiman added 2 commits June 5, 2017 09:04

cmd/evm,logger: added jsonlogger which does not accumulate logs, adde…

c437b70

…d prestate

cmd/evm: better json output, add result to json

567f695

holiman force-pushed the evmfuzz branch 2 times, most recently from 129ac97 to 34ffdb3 Compare June 5, 2017 07:13

core/vm, cmd/evm: Add ability for 'evm' binary to report gas used

21ac4dd

holiman force-pushed the evmfuzz branch 2 times, most recently from aa4af37 to 21ac4dd Compare June 5, 2017 07:21

fjl requested changes Jun 6, 2017

View reviewed changes

holiman modified the milestones: 1.6.6, 1.6.4 Jun 6, 2017

cmd/evm: Added 'sender'-flag

581dd37

holiman force-pushed the evmfuzz branch from b1f5545 to 399d736 Compare June 7, 2017 12:44

core/vm: use json codec to generate structlog json

373f587

holiman force-pushed the evmfuzz branch from 399d736 to 373f587 Compare June 7, 2017 12:48

holiman changed the title ~~cmd/evm: add --genesis and --json options~~ Make EVM binary support prestate, and output JSON Jun 7, 2017

fjl added 2 commits June 7, 2017 15:01

cmd/evm: fixups for json logger

0e250ab

core/vm: fixup formatting

2561ab9

fjl approved these changes Jun 7, 2017

View reviewed changes

fjl changed the title ~~Make EVM binary support prestate, and output JSON~~ cmd/evm: add --prestate, --sender, --json flags for fuzzing Jun 7, 2017

fjl merged commit 80f7c6c into ethereum:master Jun 7, 2017

janx mentioned this pull request Jun 13, 2017

Evm tool for fuzz testing ethereum/pyethereum#746

Merged

holiman added a commit to holiman/go-ethereum that referenced this pull request Jun 19, 2017

cmd/evm: add --prestate, --sender, --json flags for fuzzing (ethereum…

bcd1470

…#14476)

cdetrio mentioned this pull request Aug 4, 2017

[WIP] cmd/evm: prestate config and json trace fixes #14900

Closed

Conversation

holiman commented May 15, 2017

Uh oh!

GitCop commented May 15, 2017

Uh oh!

holiman commented May 15, 2017

Uh oh!

holiman commented May 19, 2017

Uh oh!

obscuren commented May 22, 2017

Uh oh!

holiman commented May 25, 2017

Uh oh!

obscuren commented Jun 1, 2017

Uh oh!

holiman commented Jun 2, 2017

Uh oh!

obscuren commented Jun 2, 2017

Uh oh!

holiman commented Jun 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fjl Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

holiman Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

fjl Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

GitCop commented Jun 7, 2017

Uh oh!

GitCop commented Jun 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

holiman commented Jun 4, 2017 •

edited

Loading