Implement server side packet handling for eth/62 and eth/63#1380
Closed
karalabe wants to merge 8 commits intoethereum:developfrom
karalabe:eth62
Closed
Implement server side packet handling for eth/62 and eth/63#1380karalabe wants to merge 8 commits intoethereum:developfrom karalabe:eth62
karalabe wants to merge 8 commits intoethereum:developfrom
karalabe:eth62
Conversation
Contributor
|
Squash commits please (once accepted) |
karalabe
changed the title
Member
Author
There was a problem hiding this comment.
It is inclusive, isn't it? As long as the length < Max, add some more.
Member
Author
|
As the full eth/62 sync logic is already finished in the top level PR, I'm closing this one down in favor of a single big merge now: #1701. |
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 2, 2025
Wrong architecture binary ended up in arm64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the "server" side of the eth/62 and eth/63 protocols. The goal of v62 is to introduce the necessary network packets for more flexible full node synchronization, whereas v63 aims to set the bases for implementing light clients. All the proposed network packets have been implemented and handled, also supporting switching the between any of the 4 currently supported protocol versions: 60 through 63.
Note, the client side of the protocols (i.e. synchronization, downloader, fetcher, etc), have not yet been updated, so enabling protocols above 62 and connecting to the main net would likely result in very undefined behavior.
However, given the scope of this PR, I would like to have a round of reviews and corrections in the current state, and only move forward with implementing the client side and updated/new sync logic after the server side core is deemed to be solid. That should desirable be done in a new PR to keep the merges clean.