Skip to content

Comments

Replace ensure with if-statements (Prague)#944

Merged
SamWilsn merged 1 commit intoethereum:forks/praguefrom
SamWilsn:ensure-prague
May 2, 2024
Merged

Replace ensure with if-statements (Prague)#944
SamWilsn merged 1 commit intoethereum:forks/praguefrom
SamWilsn:ensure-prague

Conversation

@SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented May 1, 2024

What was wrong?

Related to Issue #588

How was it fixed?

See #932

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.04167% with 95 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (forks/prague@afa50ad). Click here to learn what that means.

Files Patch % Lines
src/ethereum/prague/fork.py 0.00% 52 Missing ⚠️
src/ethereum/prague/vm/instructions/system.py 0.00% 8 Missing ⚠️
src/ethereum/prague/vm/instructions/storage.py 0.00% 6 Missing ⚠️
...rague/vm/precompiled_contracts/point_evaluation.py 0.00% 6 Missing ⚠️
src/ethereum/prague/vm/instructions/stack.py 0.00% 4 Missing ⚠️
src/ethereum/prague/vm/interpreter.py 0.00% 4 Missing ⚠️
...ereum/prague/vm/precompiled_contracts/alt_bn128.py 0.00% 4 Missing ⚠️
...thereum/prague/vm/precompiled_contracts/blake2f.py 0.00% 4 Missing ⚠️
src/ethereum/prague/state.py 0.00% 2 Missing ⚠️
src/ethereum/prague/vm/instructions/environment.py 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@               Coverage Diff               @@
##             forks/prague     #944   +/-   ##
===============================================
  Coverage                ?   70.60%           
===============================================
  Files                   ?      684           
  Lines                   ?    37890           
  Branches                ?        0           
===============================================
  Hits                    ?    26751           
  Misses                  ?    11139           
  Partials                ?        0           
Flag Coverage Δ
unittests 70.60% <1.04%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamWilsn SamWilsn merged commit d3ffe5e into ethereum:forks/prague May 2, 2024
@SamWilsn SamWilsn deleted the ensure-prague branch May 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants