checks for a transaction in cancun#935
Merged
gurukamath merged 1 commit intoethereum:masterfrom Apr 22, 2024
Merged
Conversation
The following changes have been made in the PR - Change the check_transaction function to include all the includibility checks for a transaction - Get rid of the validate_transaction function and incorporate it within the check_transaction function. - Change the order of the check_transaction function inputs to reflect the chronological order of the forks in which the parameters were introduced. - Update the check_transaction function of the t8n tool work with the new signature of check_transaction for cancun. Note: This is the rtemporary change and the final version of this function can only be implemented after the changes have been ported over to the other forks. - Replace the use of ensure with explicit if statements.
SamWilsn
approved these changes
Apr 22, 2024
Bbjj88h
approved these changes
May 2, 2024
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Oct 16, 2025
…ixtureConsumer` (ethereum#935) * refactor(ethereum_clis): move `TransitionTool.verify_fixture()` to `Statetest` & `Blocktest` docs: update changelog chore: clean-out currently unused code from `test_statetest` fix(clis): ruff fix(fixtures): ruff refactor(clis,fixtures): Refactor FixtureConsumer into two separate classes refactor(clis): Rename file refactor(plugins): Parametrize direct with all consumers, make `fixture_format` a mandatory parameter fix(plugins/consume): nit fix(plugins/consume,fixtures,clis): remove geth-specific workarounds, generalize consume direct test fix(clis): Fix geth state test consume fix(plugins/filler): Generalize fixture verifier * rename function * Remove duplicate parametrization * Rename `t8n_subcommand` to `subcommand` * Refactor `FixtureConsumer` * docs: reword changelog --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
danceratopz
added a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…ixtureConsumer` (ethereum#935) * refactor(ethereum_clis): move `TransitionTool.verify_fixture()` to `Statetest` & `Blocktest` docs: update changelog chore: clean-out currently unused code from `test_statetest` fix(clis): ruff fix(fixtures): ruff refactor(clis,fixtures): Refactor FixtureConsumer into two separate classes refactor(clis): Rename file refactor(plugins): Parametrize direct with all consumers, make `fixture_format` a mandatory parameter fix(plugins/consume): nit fix(plugins/consume,fixtures,clis): remove geth-specific workarounds, generalize consume direct test fix(clis): Fix geth state test consume fix(plugins/filler): Generalize fixture verifier * rename function * Remove duplicate parametrization * Rename `t8n_subcommand` to `subcommand` * Refactor `FixtureConsumer` * docs: reword changelog --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some incredibility checks were in the
process_transactionfunction instead of thecheck_transactionfunctionRelated to Issue #799
How was it fixed?
The following changes have been made in the PR
check_transactionfunction to include all the includibility checks for a transactionvalidate_transactionfunction and incorporate it within thecheck_transactionfunction.check_transactionfunction inputs to reflect the chronological order of the forks in which the parameters were introduced.check_transactionfunction of the t8n tool work with the new signature of check_transaction forcancun. Note: This is a temporary change and the final version of this function can only be implemented after the changes have been ported over to the other forks.ensurewith explicit if statements.Cute Animal Picture