Skip to content

Comments

Document base_types.py#883

Merged
petertdavies merged 11 commits intomasterfrom
markdown
Mar 8, 2024
Merged

Document base_types.py#883
petertdavies merged 11 commits intomasterfrom
markdown

Conversation

@SamWilsn
Copy link
Contributor

This PR removes some unnecessary constants, renames some classes for consistency, and updates base_types.py to markdown.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.12%. Comparing base (4d95303) to head (6fe5c0a).
Report is 391 commits behind head on master.

Files with missing lines Patch % Lines
...c/ethereum/arrow_glacier/vm/instructions/memory.py 0.00% 2 Missing ⚠️
src/ethereum/dao_fork/vm/instructions/memory.py 0.00% 2 Missing ⚠️
...rc/ethereum/gray_glacier/vm/instructions/memory.py 0.00% 2 Missing ⚠️
...rc/ethereum/muir_glacier/vm/instructions/memory.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         572      572           
  Lines       32419    32423    +4     
=======================================
+ Hits        24030    24034    +4     
  Misses       8389     8389           
Flag Coverage Δ
unittests 74.12% <87.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petertdavies petertdavies merged commit de09773 into master Mar 8, 2024
SamWilsn added a commit that referenced this pull request Mar 8, 2024
gurukamath added a commit that referenced this pull request Mar 9, 2024
@SamWilsn SamWilsn deleted the markdown branch April 10, 2024 21:59
SamWilsn added a commit that referenced this pull request Apr 15, 2024
SamWilsn added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants