Implement EIP-4844#867
Merged
Merged
Conversation
SamWilsn
reviewed
Feb 1, 2024
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
I haven't really reviewed for correctness, just for readability and pythonic-ness.
| parent_beacon_block_root: Root, | ||
| ) -> Tuple[Uint, Root, Root, Bloom, State, Root]: | ||
| excess_blob_gas: U64, | ||
| ) -> Tuple[Uint, Root, Root, Bloom, State, Root, Uint]: |
Contributor
There was a problem hiding this comment.
Should we make a dataclass for this? It's getting really unwieldy.
| preaccessed_addresses.add(env.coinbase) | ||
| if isinstance(tx, (AccessListTransaction, FeeMarketTransaction)): | ||
| if isinstance( | ||
| tx, (AccessListTransaction, FeeMarketTransaction, BlobTransaction) |
Contributor
There was a problem hiding this comment.
Should we make (and backport) a has_access_list function? Not specifically for this pull request, just in general.
Contributor
Author
There was a problem hiding this comment.
Would probably make the maintaining of these properties easier.
Edit: Apparently, mypy is unable to infer the narrowing of types if done inside another function.
This was referenced Feb 1, 2024
This was referenced Feb 5, 2024
Closed
SamWilsn
approved these changes
Feb 5, 2024
Contributor
Author
|
The currently failing CI is because of missing |
hwwhww
reviewed
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-4844 was not implemented in the specs
Related to Issue #848
How was it fixed?
Implemented EIP-4844. Updated the evm tools to account for the changes.
Cute Animal Picture