Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIPs to CFI, based on ACD150 #656

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Add EIPs to CFI, based on ACD150 #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1821fa6
Add EIPs to CFI, based on ACD150
timbeiko Nov 24, 2022
b6ca5c1
Clarify CFI != "this upgrade"
timbeiko Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions network-upgrades/mainnet-upgrades/shanghai.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
## Shanghai Network Upgrade Specification

### Included EIPs
Specifies changes included in the Network Upgrade.
Changes included in the Network Upgrade.

* [EIP-3651: Warm COINBASE](https://eips.ethereum.org/EIPS/eip-3651)
* [EIP-3855: PUSH0 instruction](https://eips.ethereum.org/EIPS/eip-3855)
* [EIP-3860: Limit and meter initcode](https://eips.ethereum.org/EIPS/eip-3860)
* [EIP-4895: Beacon chain push withdrawals as operations](https://eips.ethereum.org/EIPS/eip-4895)

### EIPs Considered for Inclusion
Specifies changes potentially included in the Network Upgrade, pending successful deployment on Client Integration Testnets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the change in definition warrants a reclassification of those EIPs already in this category, for example i think transient storage was CFI for shanghai meaning that assuming it did not delay shanghai or present issues during testing it would be included, but this change makes that far less clear

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moodysalem in the interest of providing an accurate view of where things are at sooner rather than later, I think I'd merge it as is. On the next ACD, I expect we'll have a clear list of what's included in Shanghai and a rough idea of what to do about other EIPs. It makes sense to revamp CFI for the next fork (as we do a bunch of other process changes as well). For 1153 specifically, I don't think it should change what we do: next step is to get it on devnets along with everything else!

Changes [Considered for Inclusion](https://github.com/ethereum/execution-specs/tree/master/network-upgrades#definitions) as part of this upgrade, or potentially future ones.

* [EIP-1153: Transient storage opcodes](https://eips.ethereum.org/EIPS/eip-1153)
* [EIP-2537: Precompile for BLS12-381 curve operations](https://eips.ethereum.org/EIPS/eip-2537)
* [EIP-3540: EVM Object Format (EOF) v1](https://eips.ethereum.org/EIPS/eip-3540)
* [EIP-3670: EOF - Code Validation](https://eips.ethereum.org/EIPS/eip-3670)
* [EIP-4200: EOF - Static relative jumps](https://eips.ethereum.org/EIPS/eip-4200)
* [EIP-4750: EOF - Functions](https://eips.ethereum.org/EIPS/eip-4750)
* [EIP-4844: Shard Blob Transactions](https://eips.ethereum.org/EIPS/eip-4844)
* [EIP-5450: EOF - Stack Validation](https://eips.ethereum.org/EIPS/eip-5450)

### Readiness Checklist

Expand Down