-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CFI EIPs #447
Add CFI EIPs #447
Conversation
Signed-off-by: Tim Beiko <[email protected]>
|
||
* [EIP-3540: EVM Object Format (EOF) v1](https://eips.ethereum.org/EIPS/eip-3540) | ||
* [EIP-3670: EOF - Code Validation](https://eips.ethereum.org/EIPS/eip-3670) | ||
* [EIP-3860: Limit and meter initcode](https://eips.ethereum.org/EIPS/eip-3860) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think also 3855 was part of that, at least some client devs referred to it, but would need to listen to the recording for confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I am actually unclear about this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holiman @MariusVanDerWijden @tkstanczak @yperbasis @shemnon @garyschulte if we could get a 👍 / 👎 from each of your teams on including PUSH0, it'd be helpful so we don't have to wait until the next call.
If you feel like we need more discussion before making a call, that's fine too. Just signal it here and we can merge these 3 and cover PUSH0 next ACD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Implementing PUSH0 is easy, the harder (but still easy) part is ensuring it doesn't leak into pre-Shanghai execution (a well trodden path with ops like chainid).
The real work is in reference tests and upstream use by solidity and friends.
That extends to all EVM work, good reference tests are more work than client implementations typically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, Ipsilon has tests for most of these EIPs (not for 3670 yet): https://github.com/ethereum/tests/pulls/gumb0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for EIP-3855 from Erigon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from geth on PUSH0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for EIP-3855 from besu mainnet team also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for the rapid responses! Will add and merge.
Signed-off-by: Tim Beiko <[email protected]>
On ACD131, we agreed to move EIPs 3540, 3670 and 3860 to CFI.