fixed log tests that were failing because gas calculations were resulting in U256 to overflow#342
Merged
SamWilsn merged 1 commit intoethereum:masterfrom Sep 15, 2021
Conversation
…lt in U256 to overflow
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 95.19% 95.04% -0.16%
==========================================
Files 45 46 +1
Lines 2291 2319 +28
==========================================
+ Hits 2181 2204 +23
- Misses 110 115 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SamWilsn
approved these changes
Sep 15, 2021
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Oct 16, 2025
…m#342) Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
danceratopz
added a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…m#342) Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some gas calculations were causing U256 to overflow.
How was it fixed?
u256_safe_addandu256_safe_multiplythat add and multiuply respectively and raiseOutOfGasErrorif the result exceedsU256.MAX_VALUE.Note
I haven't applied the new safe arithmetic methods in other places where gas calculation could possibly overflow. I can do this in a separate PR.
Cute Animal Picture
Pic credits: www.homeoanimal.com