chore(do not merge): Experiment on docc#2296
Closed
kevaundray wants to merge 5 commits intoethereum:forks/amsterdamfrom
Closed
chore(do not merge): Experiment on docc#2296kevaundray wants to merge 5 commits intoethereum:forks/amsterdamfrom
docc#2296kevaundray wants to merge 5 commits intoethereum:forks/amsterdamfrom
Conversation
Contributor
Author
|
@danceratopz I'm guessing the main optimization you was talking about was caching the call to I think we can close #2271 @SamWilsn and wait for Dan's changes in |
7 tasks
Contributor
Author
|
@danceratopz perhaps we can upstream 1893ba2 first since its just caching and should be easy to test? We could even do a test that calls Also can see an issue on this by @SamWilsn SamWilsn/docc#35 |
Contributor
Author
|
Ah I wasn't aware of |
Contributor
Author
|
Closing since we have #2304 which skips the diffs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
docc has been vendored in as this is just out of curiousity
Was curious to see the bottlenecks that Dan was talking about. From what I profiled, it seems docc creates a new HTMLVisitor every time it needs to convert a node to HTML. So I tried to add some caching to see the performance. Will close once experiment is done.
Essentially imagine you need to lookup a phone number N times. Instead of looking up once and writing it down, you look it up N times.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture