Skip to content

refactor(test-benchmarks): ensure SSTORE N->N writes nonzero key/value #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouisTsai-Csie merged 2 commits into from
Feb 24, 2026
Merged

refactor(test-benchmarks): ensure SSTORE N->N writes nonzero key/value #2255

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b686f8b
fix(benchmarks): ensure sstore N->N writes nonzero key/value
jochem-brouwer Feb 20, 2026
c2caf0e
fix: linting issue
LouisTsai-Csie Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/benchmark/compute/instruction/test_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,9 @@ def test_storage_access_warm_benchmark(
"""
match storage_action:
case StorageAction.WRITE_SAME_VALUE:
attack_block = Op.SSTORE(Op.PUSH0, Op.PUSH0)
# Timestamp is nonzero (no txs run in Genesis block), so this always writes
# to the zero key a nonzero, constant value
attack_block = Op.SSTORE(Op.PUSH0, Op.TIMESTAMP)
Comment thread
LouisTsai-Csie marked this conversation as resolved.
case StorageAction.WRITE_NEW_VALUE:
attack_block = Op.SSTORE(Op.PUSH0, Op.GAS)

@misilva73 misilva73 Feb 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was fine, no? It was writing a different value (Op.GAS) to the same slot (slot 0)

case StorageAction.READ:
Expand Down
Loading