Skip to content

🧹 chore(tests): Remove duplicate 7708 test#2206

Closed
raxhvl wants to merge 0 commit into
ethereum:eips/amsterdam/eip-7708from
raxhvl:eips/amsterdam/eip-7708
Closed

🧹 chore(tests): Remove duplicate 7708 test#2206
raxhvl wants to merge 0 commit into
ethereum:eips/amsterdam/eip-7708from
raxhvl:eips/amsterdam/eip-7708

Conversation

@raxhvl
Copy link
Copy Markdown
Member

@raxhvl raxhvl commented Feb 13, 2026

🗒️ Description

Both test_selfdestruct_during_initcode (test_transfer_logs.py) and test_selfdestruct_to_different_address_same_tx (test_selfdestruct_logs.py)
- use a factory contract to deploy a new contract → initcode SELFDESTRUCTs to beneficiary
- Both parameterized by CREATE/CREATE2

test_selfdestruct_to_different_address_same_tx also parameterizes balance (0/2000), making it a superset, removed the other one.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • [ x] All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@raxhvl raxhvl requested a review from spencer-tb February 13, 2026 09:39
@raxhvl raxhvl added the C-test Category: test label Feb 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (bf16746) to head (772a410).
⚠️ Report is 77 commits behind head on eips/amsterdam/eip-7708.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2206      +/-   ##
===========================================================
- Coverage                    86.14%   84.14%   -2.01%     
===========================================================
  Files                          599      642      +43     
  Lines                        39491    42267    +2776     
  Branches                      3782     4066     +284     
===========================================================
+ Hits                         34021    35566    +1545     
- Misses                        4848     5971    +1123     
- Partials                       622      730     +108     
Flag Coverage Δ
unittests 84.14% <ø> (-2.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fselmo fselmo force-pushed the eips/amsterdam/eip-7708 branch from f143c2b to 0515d58 Compare February 13, 2026 18:04
@fselmo fselmo closed this Feb 13, 2026
@fselmo fselmo force-pushed the eips/amsterdam/eip-7708 branch from 772a410 to 0515d58 Compare February 13, 2026 18:37
@fselmo fselmo mentioned this pull request Feb 13, 2026
5 tasks
@fselmo
Copy link
Copy Markdown
Contributor

fselmo commented Feb 13, 2026

I think the branch name clash here made this tough to rebase. Not sure what happened but I cherry-picked your commit to #2210.

@raxhvl raxhvl deleted the eips/amsterdam/eip-7708 branch February 14, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants