refactor(tests): Add fork parameter to Initcode generator #2176
+143
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initcode class now uses fork-specific gas costs and memory expansion formula instead of hardcoded values. Co-Authored-By: Claude Opus 4.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2176 +/- ##
================================================
Coverage 86.07% 86.07%
================================================
Files 599 599
Lines 39472 39472
Branches 3780 3780
================================================
Hits 33977 33977
Misses 4862 4862
Partials 633 633
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
Feb 9, 2026
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Thanks for this! Some comments I think might be good to get addressed before merging.
packages/testing/src/execution_testing/tools/tools_code/generators.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/tools/tools_code/generators.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/tools/tools_code/generators.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mario Vega <[email protected]>
pdobacz
force-pushed
the
refactor/initcode-generator
branch
from
5e17cc9 to
e686959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Initcode class now uses fork-specific gas costs and memory expansion formula instead of hardcoded values.
This should make tests leveraging this generator less sensitive to gas repricings. An EIP-3860 test needed to be adapted a bit, to not hardcode
Initcodeinstances in parameters.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.