chore: update style guidelines#2158
Merged
SamWilsn merged 2 commits intoethereum:forks/amsterdamfrom Feb 11, 2026
Merged
Conversation
fselmo
approved these changes
Feb 6, 2026
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm, minor spelling correction but approving to unblock once that's in
| # EIP-1234: The dingus is the rate of fleep | ||
| dingus = a + b | ||
|
|
||
| # EIP-4567: Frobulate the dingus |
danceratopz
reviewed
Feb 9, 2026
Member
danceratopz
left a comment
danceratopz
left a comment
There was a problem hiding this comment.
Looks good @SamWilsn! Just one question below regarding docstrings.
| The marked lines (`<-`) are now incorrectly attributed to EIP-4567 in Fork+1. Instead, omit the EIP identifier in the comments, and describe the changes introduced by the EIP in the function's docstrings. The rendered diffs will make it pretty obvious what's changed. | ||
| </details> | ||
|
|
||
| #### Docstrings |
Member
There was a problem hiding this comment.
Sam, was a standard ever set for EELS docstrings to be either declarative (numpy) or imperative (PEP 257). I spotted that we currently use both, perhaps we can try to stick to one going forward?
For example:
- Imperative:
- Indicative:
Contributor
Author
There was a problem hiding this comment.
That's a good question. I have no idea.
Personally, my top priority is eventually getting to something like the CL annotated spec. I'm not sure the various projects attempting to do that agree on much though.
RazorClient
pushed a commit
to RazorClient/execution-specs
that referenced
this pull request
Feb 11, 2026
Co-authored-by: felipe <fselmo2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cute Animal Picture