Skip to content

fix(test-fill): stream fixture JSON writes to reduce peak memory #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fselmo merged 1 commit into from
Feb 3, 2026
Merged

fix(test-fill): stream fixture JSON writes to reduce peak memory #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/testing/src/execution_testing/fixtures/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,15 @@ def merge_partial_fixture_files(output_dir: Path) -> None:

# Write final JSON file
sorted_keys = sorted(entries.keys())
parts = ["{\n"]
last_idx = len(sorted_keys) - 1
for i, key in enumerate(sorted_keys):
key_json = json.dumps(key)
# Add indentation for nesting inside outer JSON object
value_indented = entries[key].replace("\n", "\n ")
parts.append(f" {key_json}: {value_indented}")
parts.append(",\n" if i < last_idx else "\n")
parts.append("}")
target_path.write_text("".join(parts))
with open(target_path, "w") as f:
f.write("{\n")
for i, key in enumerate(sorted_keys):
key_json = json.dumps(key)
value_indented = entries[key].replace("\n", "\n ")
f.write(f" {key_json}: {value_indented}")
f.write(",\n" if i < last_idx else "\n")
f.write("}")

# Clean up partial files
for partial in partials:
Expand Down
Loading