Skip to content

fix(test-benchmark): skip rlp size limit check #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danceratopz merged 1 commit into from
Feb 3, 2026
Merged

fix(test-benchmark): skip rlp size limit check #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/benchmark/compute/scenario/test_transaction_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,13 @@ def test_block_full_access_list_and_data(
Test a block with access lists (60% gas) and calldata (40% gas) using
random mixed bytes.
"""
# Skip if EIP-7934 block RLP size limit would be exceeded
Copy link
Member

@danceratopz danceratopz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we'd like to re-enable when filling for Osaka, we could consider changing the skip to a warning?

Copy link
Member

@danceratopz danceratopz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will hard fail upon update to Osaka, so we'll get a reminder ;-)

Copy link
Collaborator Author

@LouisTsai-Csie LouisTsai-Csie Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an issue #2119 for tracking! This should be revisited later for refactor.

block_rlp_limit = fork.block_rlp_size_limit()
if block_rlp_limit:
pytest.skip(
"Test skipped: EIP-7934 block RLP size limit might be exceeded"
)

iteration_count = math.ceil(gas_benchmark_value / tx_gas_limit)

gas_remaining = gas_benchmark_value
Expand Down
Loading