Skip to content

fix(test,benchmark): cap data tests to rlp block limit#2110

Closed
fselmo wants to merge 1 commit intoethereum:forks/amsterdamfrom
fselmo:fix/failing-osaka-block-test
Closed

fix(test,benchmark): cap data tests to rlp block limit#2110
fselmo wants to merge 1 commit intoethereum:forks/amsterdamfrom
fselmo:fix/failing-osaka-block-test

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Jan 31, 2026

🗒️ Description

  • Consider RLP limit for max data test... this does cap the data gas at the RLP limit so takes the min between the benchmark gas value and the rlp limit... I think this is OK? But we'd have to consider the intent of the test. Not sure there's another way tbh?
  • Use vars instead of hard-coded values for fixtures

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-01-30 at 17 09 31

@fselmo fselmo closed this Jan 31, 2026
@fselmo
Copy link
Contributor Author

fselmo commented Jan 31, 2026

meant to PR this here

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (2c549ce) to head (f352f43).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2110   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant