Skip to content

Conversation

@felix314159
Copy link
Contributor

@felix314159 felix314159 commented Jan 27, 2026

🗒️ Description

  1. Fix: deterministic factory is now pre-deployed in the genesis, so u can do execute hive again because there is no need to allow unprotecte transactions anymore
  2. Another fix that adds BAL support to execute hive
  3. QoL fix that does not let blobs spam terminal with RLP data in case of failure (upper cap on printed chars)
  4. Fixes flaw in blobs test where it tried to put 7 blobs for amsterdam when upper cap is 6
  5. Framework improvements for testing different getBlobsVX behaviors, we can now explicitely tests getBlobsV1, V2 and V3
  6. Adds warning when user tries to fill a blobs test (would just fill 0 without telling why). it is non-obvious that you are supposed to use execute hive for blobs tests, the printed warning clearly states that now

How to test:
Run latest hive with bal-devnet-2 geth, then run:
uv run execute hive -v -s ./tests/osaka/eip7594_peerdas/test_get_blobs.py --fork=amsterdam

-> all 24 tests pass with the fixes this PR contains

🔗 Related Issues or PRs

engine_getBlobsV3 PR

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (cad8b90) to head (4a7a2c2).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2085   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felix314159 felix314159 marked this pull request as ready for review January 29, 2026 16:32
@felix314159 felix314159 changed the base branch from forks/amsterdam to devnets/bal/2 February 2, 2026 11:10
@fselmo fselmo force-pushed the devnets/bal/2 branch 2 times, most recently from f26caad to 763699b Compare February 3, 2026 21:44
@felix314159
Copy link
Contributor Author

felix314159 commented Feb 4, 2026

After the docs-fixes PR is merged I will rebase this getBlobsV3 PR again.

Edit: Ready for review now

@felix314159 felix314159 changed the base branch from devnets/bal/2 to forks/amsterdam February 6, 2026 16:11
@felix314159
Copy link
Contributor Author

Ready for review/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant