Skip to content

chore(test-specs): fix fork transition tests #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marioevz merged 3 commits into from
Jan 23, 2026
Merged

chore(test-specs): fix fork transition tests #2065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eca8d6e
chore(test-specs): fix fork transition tests
spencer-tb Jan 22, 2026
fce1b43
fix(test-forks): don't collect BPO tests w/ unchanged params on trans…
fselmo Jan 22, 2026
9b7e0e3
refactor(test-forks): clearer definitions for transition forks
fselmo Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/testing/src/execution_testing/forks/forks/transition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
BPO2,
BPO3,
BPO4,
Amsterdam,
Berlin,
Cancun,
London,
Expand Down Expand Up @@ -66,6 +67,17 @@ class BPO1ToBPO2AtTime15k(BPO1):
pass


@transition_fork(to_fork=Amsterdam, at_timestamp=15_000)
class BPO2ToAmsterdamAtTime15k(BPO2):
"""BPO2 to Amsterdam transition at Timestamp 15k."""

# TODO: We may need to adjust which BPO Amsterdam inherits from as the
# related Amsterdam specs change over time, and before Amsterdam is
# live on mainnet.

pass


@transition_fork(to_fork=BPO3, at_timestamp=15_000)
class BPO2ToBPO3AtTime15k(BPO2):
"""BPO2 to BPO3 transition at Timestamp 15k."""
Expand Down
4 changes: 3 additions & 1 deletion tests/osaka/eip7918_blob_reserve_price/test_blob_reserve_price_with_bpo_transitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,9 @@ def get_fork_scenarios(fork: Fork) -> Iterator[ParameterSet]:
],
get_fork_scenarios,
)
@pytest.mark.valid_at_transition_to("Osaka", subsequent_forks=True)
@pytest.mark.valid_at_transition_to(
"Osaka", subsequent_forks=True, until="BPO4"
)
Comment thread
fselmo marked this conversation as resolved.
Outdated
@pytest.mark.valid_for_bpo_forks()
def test_reserve_price_at_transition(
blockchain_test: BlockchainTestFiller,
Expand Down
Loading