feat(spec-tests): add eip-7778 tests for calldata checks by gurukamath · Pull Request #2060 · ethereum/execution-specs

gurukamath · 2026-01-22T14:26:58Z

🗒️ Description

Adds tests for different scenarios involving the call data floor cost of a transaction. Specifically,

1. calldata_floor < tx_gas_after_refund
2. tx_gas_after_refund < calldata_floor < tx_gas_before_refund
3. calldata_floor > tx_gas_before_refund

🔗 Related Issues or PRs

#1874

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx tox -e static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered updating the online docs in the ./docs/ directory.

Cute Animal Picture

LouisTsai-Csie

LGTM! Small change to use the gas cost calculator

codecov · 2026-01-22T16:19:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (e958b62) to head (b346d83).
⚠️ Report is 90 commits behind head on eips/amsterdam/eip-7778.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7778    #2060      +/-   ##
===========================================================
- Coverage                    86.33%   86.16%   -0.17%     
===========================================================
  Files                          538      599      +61     
  Lines                        34557    39530    +4973     
  Branches                      3222     3780     +558     
===========================================================
+ Hits                         29835    34062    +4227     
- Misses                        4148     4847     +699     
- Partials                       574      621      +47

Flag	Coverage Δ
unittests	`86.16% <ø> (-0.17%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com>

marioevz

LGTM, thanks!

Only two small comments.

* feat(spec-tests): add eip-7778 for calldata checks * feat(spec-tests): post review - use code gas_cost function Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com>

@gurukamath

…ut refunds (#2840) * feat(spec-specs): Implement EIP-7778 Block Gas Accounting without Refunds (#1401) * feat(specs): add eip-7778 implementation * fix(specs) spliting receipt gas from block gas * revert receipt_gas_used * make sure that the calldata floor cost overwrites the tx gas before refund * receipt gas used after refunds * clarify variable naming @gurukamath * revert to using gas used after refunds for cumulative gas in receipt and add gasSpent to receipt * spec(amsterdam): fix code formatting --------- Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> * fix(tests): fix legacy tests to run with eip-7778 (#2048) * fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam * feat(spec-tests): add basic eip7778 test (#2045) * feat(spec-tests): add eip-7778 tests for calldata checks (#2060) * feat(spec-tests): add eip-7778 for calldata checks * feat(spec-tests): post review - use code gas_cost function Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com> * fix(tests): Fix gas used/spent in EIP-7702 tests (#2068) * feat(spec-specs): use post refund gas in receipts in EIP-7778 (#2073) * fix(test): Update refspec for EIP-7778 to match latest revision (#2093) * feat(test-forks): Add EIP-7778 * refactor(tests): Condition EIP-7778 tests to EIP inclusion * fix(test): use deterministic iteration order for refund types The set iteration in `build_refund_tx` is non-deterministic due to Python's hash randomization, causing fixture output to vary between runs. Sort by enum value to ensure reproducible fixtures. * doc: remove changelog md * fix: broken auth tx benchmark * doc: add eip checklist * fix: typo * Update tests/benchmark/compute/scenario/test_transaction_types.py * Apply suggestions from code review Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: Toni Wahrstätter <51536394+nerolation@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: felipe <fselmo2@gmail.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org>

gurukamath mentioned this pull request Jan 22, 2026

EIP-7778 Implementation Tracker: Block Gas Accounting without Refunds #1874

Open

20 tasks

gurukamath requested a review from LouisTsai-Csie January 22, 2026 14:29

gurukamath force-pushed the eips/amsterdam/eip-7778 branch from abca655 to 927849e Compare January 22, 2026 14:53

feat(spec-tests): add eip-7778 for calldata checks

7e70d56

gurukamath force-pushed the eip-7778/varying-calldata-tests branch from 5f0166a to 7e70d56 Compare January 22, 2026 15:17

LouisTsai-Csie requested changes Jan 22, 2026

View reviewed changes

feat(spec-tests): post review - use code gas_cost function

dc40041

Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com>

gurukamath requested a review from marioevz January 22, 2026 17:21

marioevz approved these changes Jan 22, 2026

View reviewed changes

Comment thread tests/amsterdam/eip7778_block_gas_accounting_without_refunds/test_gas_accounting.py Outdated

Comment thread tests/amsterdam/eip7778_block_gas_accounting_without_refunds/test_gas_accounting.py Outdated

Apply suggestions from code review

b346d83

fselmo added this to the bal devnet-2 milestone Jan 22, 2026

marioevz merged commit 451f4db into ethereum:eips/amsterdam/eip-7778 Jan 22, 2026
17 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(spec-tests): add eip-7778 tests for calldata checks#2060

feat(spec-tests): add eip-7778 tests for calldata checks#2060
marioevz merged 3 commits into
ethereum:eips/amsterdam/eip-7778from
gurukamath:eip-7778/varying-calldata-tests

gurukamath commented Jan 22, 2026

Uh oh!

LouisTsai-Csie left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

marioevz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gurukamath commented Jan 22, 2026

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

LouisTsai-Csie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jan 22, 2026 •

edited

Loading