feat(src): EIP-7843 (SLOTNUM) Draft#2007
feat(src): EIP-7843 (SLOTNUM) Draft#2007fselmo merged 2 commits intoethereum:eips/amsterdam/eip-7843from
Conversation
|
Rebased the remote eip7843 branch on |
marioevz
left a comment
There was a problem hiding this comment.
Looks fantastic! I added two small comments only. Thanks!
|
I rebased on top of |
|
Ok the target EIP branch is now also rebased on |
spencer-tb
left a comment
There was a problem hiding this comment.
Some small comments.
Quick tests to include in another PR:
- Fork transitions tests, verify invalid pre fork, valid on fork block and after.
- Call context, verify
slot_numberis consistent in nested call. - Initcode context, verify
slot_numberin constructor via direct tx and via CREATE/CREATE2.
fselmo
left a comment
There was a problem hiding this comment.
I rebased this and it lgtm 👍🏼. I'm going to address a failing test for 7934 and Spencer's comments in a followup PR.
8682b5d
into
ethereum:eips/amsterdam/eip-7843
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following ethereum#2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following #2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
🗒️ Description
uv run fill tests/amsterdam/eip7843_slotnum/test_slotnum.py -v --clean --until=Amsterdam.successfully tested against geth's bal-devnet-2 branch after applying these fixes. btw in
hive/clients/go-ethereumi used the genesis that ethpandaops provided for bal-devnet-1🔗 Related Issues or PRs
Solves #1876
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture