chore(test-types): Add extra="forbid" to CamelModel; fix errors#1989
Merged
fselmo merged 2 commits intoethereum:forks/amsterdamfrom Jan 8, 2026
Merged
chore(test-types): Add extra="forbid" to CamelModel; fix errors#1989fselmo merged 2 commits intoethereum:forks/amsterdamfrom
extra="forbid" to CamelModel; fix errors#1989fselmo merged 2 commits intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1989 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
79e3c6e to
a6dcded
Compare
a6dcded to
4dc89fd
Compare
marioevz
approved these changes
Jan 8, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
LGTM, just one question of a change I didn't quite understand. Thanks!
8 tasks
8 tasks
8 tasks
jsign
pushed a commit
to jsign/execution-specs
that referenced
this pull request
Jan 20, 2026
…oc-groups` (ethereum#1989) * refactor: don't hard-code gas limit; pull from env * bugfix: Use sender fixture for all block calculations - If a signed transaction has leading zeros in any of the signature fields, the rlp encoding will remove those leading zeros. When we swapped the real sender in, the signature would change and we could have a variability in the block rlp size. So we should use the ``sender`` fixture for the original transaction building and pass those original transactions to the final block instead of swapping senders (unnecessary).
jsign
pushed a commit
to jsign/execution-specs
that referenced
this pull request
Jan 20, 2026
…oc-groups` (ethereum#1989) * refactor: don't hard-code gas limit; pull from env * bugfix: Use sender fixture for all block calculations - If a signed transaction has leading zeros in any of the signature fields, the rlp encoding will remove those leading zeros. When we swapped the real sender in, the signature would change and we could have a variability in the block rlp size. So we should use the ``sender`` fixture for the original transaction building and pass those original transactions to the final block instead of swapping senders (unnecessary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I'm still seeing issues from time to time where test writers (including myself) can misspell a kwarg to a test class which could go unnoticed with unintended consequences. This is an attempt to tighten up the pydantic models in our testing framework and prevent these sorts of issues.
extra="forbid"inCamelModelwhich our test types inherit fromextra="allow"with a clarifying message on why we want to / need to do it here.model_configfor classes that inherit fromCamelModel🔗 Related Issues or PRs
extra_forbidtoCamelModeland fix errors #1612✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture