refactor(test): rename gas cost constant#1870
refactor(test): rename gas cost constant#1870LouisTsai-Csie wants to merge 43 commits intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1870 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix(ci): Speed up slow unit tests by reusing t8n server * refactor(fill): add flag to more tests * fix(filler): flag
3d2eede to
9e161b6
Compare
Carsons-Eels
left a comment
There was a problem hiding this comment.
Overall I think it looks good, only two small things to address
| TARGET_BLOB_GAS_PER_BLOCK = GAS_PER_BLOB * BLOB_SCHEDULE_TARGET | ||
| BLOB_BASE_COST = Uint(2**13) | ||
| BLOB_SCHEDULE_MAX = U64(21) | ||
| BLOB_SCHEDULE_MAX = U64(9) | ||
| MIN_BLOB_GASPRICE = Uint(1) |
There was a problem hiding this comment.
| TARGET_BLOB_GAS_PER_BLOCK = GAS_PER_BLOB * BLOB_SCHEDULE_TARGET | |
| BLOB_BASE_COST = Uint(2**13) | |
| BLOB_SCHEDULE_MAX = U64(21) | |
| BLOB_SCHEDULE_MAX = U64(9) | |
| MIN_BLOB_GASPRICE = Uint(1) | |
| BLOB_TARGET_GAS_PER_BLOCK = GAS_PER_BLOB * BLOB_SCHEDULE_TARGET | |
| BLOB_BASE_COST = Uint(2**13) | |
| BLOB_SCHEDULE_MAX = U64(9) | |
| BLOB_MIN_GASPRICE = Uint(1) |
I think it makes more sense to name them this way, so that when you're programming the autocomplete suggestions pop up the same way for everything that is BLOB*.
5bd81af to
457d8f0
Compare
|
I accidentally change some variable name, which is not part of the gas cost constant, i hope it would not break anything. Resolve some issue by 921cabf Other notes: I found there is |
Yeah, no problem, I'll check it |
921cabf to
5c1ff6f
Compare
5c1ff6f to
a85871d
Compare
|
This PR needs a rebase 😱. Any blockers here? |
|
Rebased, updated, and passed two reviews at github.com//pull/2094 |
🗒️ Description
GAS_JUMPDESTG_JUMPDESTGAS_BASEG_BASEGAS_VERY_LOWG_VERY_LOWGAS_MEMORYG_MEMORYGAS_COPYG_COPYGAS_LOWG_LOWGAS_MIDG_MIDGAS_HIGHG_HIGHGAS_WARM_ACCESSG_WARM_SLOADGAS_COLD_SLOADG_COLD_SLOADGAS_STORAGE_UPDATEG_STORAGE_RESETGAS_STORAGE_CLEAR_REFUNDR_STORAGE_CLEARGAS_STORAGE_SETG_STORAGE_SETGAS_WARM_ACCESSG_WARM_ACCOUNT_ACCESSGAS_COLD_ACCOUNT_ACCESSG_COLD_ACCOUNT_ACCESSGAS_INIT_CODE_WORD_COSTG_INITCODE_WORDGAS_CODE_DEPOSITG_CODE_DEPOSIT_BYTEGAS_CREATEG_CREATEGAS_CALL_STIPENDG_CALL_STIPENDGAS_SELF_DESTRUCTG_SELF_DESTRUCTGAS_CALL_VALUEG_CALL_VALUEGAS_NEW_ACCOUNTG_NEW_ACCOUNTGAS_EXPONENTIATIONG_EXPGAS_EXPONENTIATION_PER_BYTEG_EXP_BYTEGAS_KECCAK256G_KECCAK_256GAS_KECCAK256_WORDG_KECCAK_256_WORDGAS_BLOCK_HASHG_BLOCKHASHGAS_LOG_DATAG_LOG_DATAGAS_LOGG_LOGGAS_LOG_TOPICG_LOG_TOPICTX_BASE_COSTG_TRANSACTIONTX_CREATE_COSTG_TRANSACTION_CREATETX_ACCESS_LIST_ADDRESS_COSTG_ACCESS_LIST_ADDRESSTX_ACCESS_LIST_STORAGE_KEY_COSTG_ACCESS_LIST_STORAGEFLOOR_CALLDATA_COSTG_TX_DATA_FLOOR_TOKEN_COSTSTANDARD_CALLDATA_TOKEN_COSTG_TX_DATA_STANDARD_TOKEN_COSTPER_EMPTY_ACCOUNT_COSTG_AUTHORIZATIONPER_AUTH_BASE_COSTR_AUTHORIZATION_EXISTING_AUTHORITYTX_DATA_COST_PER_ZEROG_TX_DATA_ZEROTX_DATA_COST_PER_NON_ZEROG_TX_DATA_NON_ZEROG_PRECOMPILE_ECADDG_PRECOMPILE_ECMULG_PRECOMPILE_ECPAIRING_BASEG_PRECOMPILE_ECPAIRING_PER_POINT🔗 Related Issues or PRs
Issue #1879
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture
I like Junji Ito.