Skip to content

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Dec 4, 2025

🗒️ Description

Updates consume / simulator doc for The Weld:

  • Updates simulator names ethereum/eest -> ethereum/eels
  • Addresses incorrect language around simulator names: EEST -> execution-specs / EELS.
  • Fixes the Dockerfile.dev example in the docs for the hive dev-mode workaround on macos.

🔗 Related Issues or PRs

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • ~All: Considered adding an entry to CHANGELOG.md.~~ skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Cute Animal Picture

image

@danceratopz danceratopz added A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume A-doc Area: documentation labels Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.87%. Comparing base (85c6fff) to head (5c6ec68).
⚠️ Report is 25 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1842      +/-   ##
===============================================
- Coverage        87.31%   83.87%   -3.45%     
===============================================
  Files              541      402     -139     
  Lines            32832    25101    -7731     
  Branches          3015     2285     -730     
===============================================
- Hits             28668    21053    -7615     
- Misses            3557     3609      +52     
+ Partials           607      439     -168     
Flag Coverage Δ
unittests 83.87% <ø> (-3.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed. Apart from that LGTM! MacOS working fine.

@danceratopz danceratopz merged commit cc82819 into ethereum:forks/osaka Dec 10, 2025
13 of 14 checks passed
jochem-brouwer pushed a commit to jochem-brouwer/execution-specs that referenced this pull request Dec 11, 2025
jochem-brouwer pushed a commit to jochem-brouwer/execution-specs that referenced this pull request Dec 11, 2025
LouisTsai-Csie pushed a commit to LouisTsai-Csie/execution-specs that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-doc Area: documentation A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants