refactor(tests): create fixture items for vm tests#1823
Merged
SamWilsn merged 4 commits intoethereum:forks/osakafrom Dec 8, 2025
Merged
refactor(tests): create fixture items for vm tests#1823SamWilsn merged 4 commits intoethereum:forks/osakafrom
SamWilsn merged 4 commits intoethereum:forks/osakafrom
Conversation
gurukamath
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1823 +/- ##
================================================
+ Coverage 53.45% 87.00% +33.55%
================================================
Files 743 743
Lines 44076 44076
Branches 3891 3891
================================================
+ Hits 23559 38347 +14788
+ Misses 20306 5224 -15082
- Partials 211 505 +294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamWilsn
approved these changes
Dec 8, 2025
|
|
||
| # Get changed files and save to disk (use absolute path for reliability) | ||
| FILE_LIST="${GITHUB_WORKSPACE}/changed_files.txt" | ||
| git diff --name-only "$BASE_SHA" "$HEAD_SHA" > "$FILE_LIST" |
Contributor
There was a problem hiding this comment.
I'm probably being overly paranoid, but I figured I'd ask: will this break if someone uploads a file with a newline? How bad could that be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR extends the pytest-based test infrastructure to cover VM, trie, and ethash tests, aligning them with the existing state and block test architecture. It also enables selective test execution based on changed files for both json_infra and optimized test environments in CI. This was previously enabled only for
json_infra.🔗 Related Issues or PRs
#1666
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture