fix(tooling): Handle AnnAssign nodes in the new fork tool#1813
Merged
SamWilsn merged 1 commit intoethereum:forks/osakafrom Nov 26, 2025
Merged
fix(tooling): Handle AnnAssign nodes in the new fork tool#1813SamWilsn merged 1 commit intoethereum:forks/osakafrom
SamWilsn merged 1 commit intoethereum:forks/osakafrom
Conversation
5 tasks
SamWilsn
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
In a recent commit, the
FORK_CRITERIAdeclarations from:FORK_CRITERIA = ByTimestamp(...) (simple assignment → cst.Assign node)
To: FORK_CRITERIA: ForkCriteria = ByTimestamp(...) (annotated assignment → cst.AnnAssign node)
The
SetConstantCommandcodemod in constant.py only handled Assign nodes, not AnnAssign nodes, so it couldn't replace the fork criteria value.✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture