fix(spec-tests): Fix new fork tool test to use last fork dynamically

[fselmo]

🗒️ Description

When we have two Unscheduled forks, which will be more frequent moving forward, while Osaka is Unscheduled and Amsterdam is too, we cannot resolve the fork criteria for the e2e test for the fork tool (e.g. here).

• We can check in builder.py if the fork is Unscheduled as well as if it's forks[-1] and raise the order_index to come after it as we already do.
• We can always use the last fork dynamically in this e2e test so that we always resolve and don't hard-code Osaka into it.

I'm not tied to the last change. If we want to make hard-coding Osaka work, we can change some other things around as well but this change does get this test passing on Amsterdam as it uses Amsterdam as the last fork.

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx tox -e static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Set appropriate labels for the changes (only maintainers can apply labels) --- question below

Cute Animal Picture

[fselmo]

Are we perhaps missing a label for spec-tests or something that signifies json_infra/ tests?

[SamWilsn]

Might be worth having a test_end_to_end_latest and keeping test_end_to_end as is. That way we can tell if the new fork tool breaks for old forks.

[fselmo]

Are we perhaps missing a label for spec-tests or something that signifies json_infra/ tests?

I added A-spec-tests. Feel free to change the description or remove it but I felt a good label for this was missing. [Hmm... I think C-test then A-spec-tool works here?]

[fselmo]

Might be worth having a test_end_to_end_latest and keeping test_end_to_end as is. That way we can tell if the new fork tool breaks for old forks.

@SamWilsn I split these to have both a hard-coded Osaka and the latest fork. I didn't see a strong reason to change the parameters for these but let me know if you think we should.

[fselmo]

Just sanity checked this by cherry-picking these commits over in Amsterdam bals branch and they pass 👌🏼

[spencer-tb]

LGTM! @SamWilsn for merge?