Rewrite new fork tool to modify blob parameters#1372
Merged
SamWilsn merged 2 commits intoethereum:forks/osakafrom Oct 3, 2025
Merged
Rewrite new fork tool to modify blob parameters#1372SamWilsn merged 2 commits intoethereum:forks/osakafrom
SamWilsn merged 2 commits intoethereum:forks/osakafrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1372 +/- ##
============================================
Coverage 86.07% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
+ Hits 37936 37938 +2
+ Misses 5659 5656 -3
- Partials 477 478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 21, 2025
SamWilsn
force-pushed
the
new-and-improved
branch
3 times, most recently
from
7909e08 to
ebd7090
Compare
gurukamath
reviewed
Aug 29, 2025
|
|
||
| blob_parameters = parser.add_argument_group() | ||
|
|
||
| blob_parameters.add_argument( |
Contributor
There was a problem hiding this comment.
This could get a bit more complicated since post-Osaka, we won't have TARGET_BLOB_GAS_PER_BLOCK as ain independent constant. See this
Contributor
Author
There was a problem hiding this comment.
Should we disable this option post-osaka or allow users to modify it at their own risk?
gurukamath
reviewed
Aug 29, 2025
SamWilsn
force-pushed
the
new-and-improved
branch
5 times, most recently
from
615b3db to
2347cb8
Compare
Contributor
Author
|
What a finicky tool. Should be good to review now. |
This was referenced Sep 10, 2025
SamWilsn
force-pushed
the
new-and-improved
branch
from
2347cb8 to
8138137
Compare
gurukamath
approved these changes
Sep 25, 2025
gurukamath
approved these changes
Sep 25, 2025
gurukamath
approved these changes
Sep 25, 2025
`actions-rs` has been archived and is no longer the recommended way to install packages. Instead, I'm using the Ubuntu-provided `rustup`.
SamWilsn
force-pushed
the
new-and-improved
branch
from
8138137 to
5877f04
Compare
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Oct 16, 2025
…-gas tests (ethereum#1372) * new(tests): EIP-7702: Delegation designation as initcode * new(tests): EIP-7702: Invalid max_fee_per_gas/max_priority_fee_per_gas * docs: changelog * refactor(tests): Combine similar cases into one Co-Authored-By: spencer <spencer.taylor-brown@ethereum.org> --------- Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…-gas tests (ethereum#1372) * new(tests): EIP-7702: Delegation designation as initcode * new(tests): EIP-7702: Invalid max_fee_per_gas/max_priority_fee_per_gas * docs: changelog * refactor(tests): Combine similar cases into one Co-Authored-By: spencer <spencer.taylor-brown@ethereum.org> --------- Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1357
How was it fixed?
Rewrote the new fork tool to be more than just find-and-replace. It now uses libcst to transform the source somewhat intelligently.
Cute Animal Picture