eips/osaka/eip 7951 #1291
Merged
eips/osaka/eip 7951 #1291
+208
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks Louis! |
gurukamath
reviewed
Jun 25, 2025
gurukamath
requested changes
Jun 25, 2025
LouisTsai-Csie
force-pushed
the
eips/osaka/eip-7951
branch
from
ff0be31 to
a571500
Compare
Collaborator
Author
|
@gurukamath Thank you for your review, I've updated based on the comment, and run the following command for linting! |
SamWilsn
reviewed
Jun 26, 2025
Comment on lines
114
to
116
| result : `ethereum.base_types.Bytes` | ||
| return 1 if the signature is valid, empty bytes otherwise |
Contributor
There was a problem hiding this comment.
This docstring doesn't match the behaviour of the function. This always returns None?
Comment on lines
128
to
129
|
|
||
| return |
|
|
||
| try: | ||
| secp256r1_verify(r, s, public_key_x, public_key_y, message_hash) | ||
| except Exception: |
Contributor
There was a problem hiding this comment.
Catching a bare Exception here can mask a lot of problems. You should catch the specific error type that you expect to be thrown.
SamWilsn
force-pushed
the
eips/osaka/eip-7951
branch
from
b10d48d to
920bd52
Compare
SamWilsn
force-pushed
the
eips/osaka/eip-7951
branch
from
920bd52 to
1f33b74
Compare
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Oct 16, 2025
…reum#1292) * chore(docs): don't include function pages in site search index ethereum#1291 * docs: update changelog
danceratopz
added a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…reum#1292) * chore(docs): don't include function pages in site search index ethereum#1291 * docs: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1244.
The previous PR #1249 could be closed, since it based on the devnets/osaka/0.
How was it fixed?
Implement EIP-7951
Description
Note on PR
PR ethereum/execution-spec-tests#1670 adds EEST test cases related to the secp256r1 (p256verify) precompile. Since it involves cryptographic operations, some dependencies on cryptography libraries are required.
If you want to run the tests locally, you should configure the appropriate settings in the ethereum-spec-evm-resolver repository to support the secp256r1 curve.
Additionally, please be aware that—per the ACD meeting on June 19 — the gas cost and return value specification for the p256verify precompile may be subject to change. Updates to the spec may affect test behavior or validity.
Cute Animal Picture