Skip to content

Encode requests correctly in t8n #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petertdavies merged 4 commits into from
Nov 25, 2024
Merged

Encode requests correctly in t8n #1040

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e18716
Remove request type byte in T8N
petertdavies Nov 22, 2024
34f100d
style: fix black
danceratopz Nov 25, 2024
6e3cb10
chore: fix mypy; requests is a list
danceratopz Nov 25, 2024
5e35d1d
Merge pull request #2 from danceratopz/fix-t8n-requests-tox
petertdavies Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ethereum_spec_tools/evm_tools/t8n/t8n_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class Result:
excess_blob_gas: Optional[U64] = None
blob_gas_used: Optional[Uint] = None
requests_hash: Optional[Hash32] = None
requests: Optional[Bytes] = None
requests: Optional[List[Bytes]] = None

def to_json(self) -> Any:
"""Encode the result to JSON"""
Expand Down Expand Up @@ -354,6 +354,10 @@ def to_json(self) -> Any:
assert self.requests is not None

data["requestsHash"] = encode_to_hex(self.requests_hash)
data["requests"] = [encode_to_hex(req) for req in self.requests]
# T8N doesn't consider the request type byte to be part of the
# request
data["requests"] = [
encode_to_hex(req[1:]) for req in self.requests
]

return data