Skip to content

Comments

chore(fill): fix prague filling with EELS#969

Merged
danceratopz merged 5 commits intomainfrom
fix/prague-filling
Nov 27, 2024
Merged

chore(fill): fix prague filling with EELS#969
danceratopz merged 5 commits intomainfrom
fix/prague-filling

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Nov 22, 2024

🗒️ Description

This PR aims to get a clean fill of ./tests/prague as of prague-devnet-4 specs with this EELS Prague fork:
https://github.com/ethereum/execution-specs/tree/forks/prague

Summary

  • ethereum-spec-evm-resolver bumped to latest available commit: c687562.
  • EELS Prague fork and ref updated, required:
  • Changed Constantinople to ConstantinopleFix in eels_resolutions.json:
  • All tests fill except for tests that provide invalid input:
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_set_code_invalid_authorization_tuple[fork_Prague-blockchain_test-invalidity_reason_InvalidityReason.EMPTY_AUTHORIZATION_LIST-transaction_exception_TransactionException.TYPE_4_EMPTY_AUTHORIZATION_LIST] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_set_code_invalid_authorization_tuple[fork_Prague-blockchain_test_engine-invalidity_reason_InvalidityReason.EMPTY_AUTHORIZATION_LIST-transaction_exception_TransactionException.TYPE_4_EMPTY_AUTHORIZATION_LIST] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_set_code_invalid_authorization_tuple[fork_Prague-state_test-invalidity_reason_InvalidityReason.EMPTY_AUTHORIZATION_LIST-transaction_exception_TransactionException.TYPE_4_EMPTY_AUTHORIZATION_LIST] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test-v=2**8] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test-r=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test-s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test-v=2**8,r=s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test_engine-v=2**8] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test_engine-r=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test_engine-s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-blockchain_test_engine-v=2**8,r=s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-state_test-v=2**8] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-state_test-r=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-state_test-s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_invalid_tx_invalid_auth_signature[fork_Prague-state_test-v=2**8,r=s=2**256] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_chain_id[fork_Prague-blockchain_test-chain_id=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_chain_id[fork_Prague-blockchain_test_engine-chain_id=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_chain_id[fork_Prague-state_test-chain_id=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_nonce[fork_Prague-blockchain_test-nonce=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_nonce[fork_Prague-blockchain_test_engine-nonce=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    FAILED tests/prague/eip7702_set_code_tx/test_set_code_txs.py::test_tx_validity_nonce[fork_Prague-state_test-nonce=2**64] - ethereum_test_specs.helpers.TransactionExceptionMismatch: 
    
  • The fixtures that do fill (on both t8ns) are a 1-to-1 match with lightclient/go-ethereum@37035c5

🔗 Related Issues

#943

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth See the eels_resolutions.json in the repository root.

@danceratopz danceratopz added type:chore Type: Chore scope:fill Scope: fill command labels Nov 22, 2024
@danceratopz danceratopz self-assigned this Nov 22, 2024
@danceratopz danceratopz marked this pull request as ready for review November 25, 2024 16:54
Previously Constantinople was specified, but EELS only supports ConstantinopleFix.

petertdavies/ethereum-spec-evm-resolver#4 makes this change necessary, as otherwise EELS will try to fill with Constantinople from execution-specs main, but this fork does not exist.
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danceratopz danceratopz merged commit 5cf1f24 into main Nov 27, 2024
@danceratopz danceratopz deleted the fix/prague-filling branch November 27, 2024 13:42
@danceratopz danceratopz added the fork:prague Prague hardfork label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:prague Prague hardfork scope:fill Scope: fill command type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants