Skip to content

new(tests): EIP-3540: execution semantics changes#571

Merged
marioevz merged 4 commits intoethereum:mainfrom
shemnon:eof/3540-extcode
Jun 6, 2024
Merged

new(tests): EIP-3540: execution semantics changes#571
marioevz merged 4 commits intoethereum:mainfrom
shemnon:eof/3540-extcode

Conversation

@shemnon
Copy link
Collaborator

@shemnon shemnon commented May 25, 2024

🗒️ Description

Test the execution semantics changes around EXTCODE* and DELEGATECALL

Covers the tests in https://github.com/ethereum/tests/blob/9c84e0db14adf4be4f93640e51f6953d583d8c49/src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_CallsFiller.yml and the EXTCODE* tests in https://github.com/ethereum/tests/blob/9c84e0db14adf4be4f93640e51f6953d583d8c49/src/EIPTestsFiller/StateTests/stEOF/stEIP3540/EOF1_ExecutionFiller.yml

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

shemnon added 2 commits May 24, 2024 19:55
Test the exectuion semantics changes around EXTCODE* and DELEGATECALL

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
Copy link
Collaborator Author

shemnon commented May 25, 2024

This build fails because it is using Geth to attempt to fill the tests, which is problematic because Geth doesn't have the features implemented that these tests are being written for.

Is gating on Geth's implementation of Prague for merging while prague is under development really a good idea? @marioevz

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests, some comments.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz merged commit 89b6cea into ethereum:main Jun 6, 2024
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* new(tests): EIP-3540: execution semantics changes

Test the exectuion semantics changes around EXTCODE* and DELEGATECALL

Signed-off-by: Danno Ferrin <danno@numisight.com>

* formatting

Signed-off-by: Danno Ferrin <danno@numisight.com>

* review requested changes

Signed-off-by: Danno Ferrin <danno@numisight.com>

---------

Signed-off-by: Danno Ferrin <danno@numisight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants