Skip to content

tests/cancun/eip_4788: Update predeploy address(0xbEAC02..7d7a), add additional tests#297

Merged
marioevz merged 10 commits intoethereum:mainfrom
spencer-tb:beacon-root-predeploy-address-update
Sep 19, 2023
Merged

tests/cancun/eip_4788: Update predeploy address(0xbEAC02..7d7a), add additional tests#297
marioevz merged 10 commits intoethereum:mainfrom
spencer-tb:beacon-root-predeploy-address-update

Conversation

@spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Sep 13, 2023

Tagging updates to 4788 from the following PR: ethereum/EIPs#7672

PR Includes

  • Update to the beacon root address & contract bytecode.
  • Additional tests cases:
    • test_invalid_beacon_root_calldata_value - asserts that zero value calldata causes revert.
    • test_beacon_root_selfdestruct - checks that self destructing to the beacon root transfers a balance.

@spencer-tb spencer-tb marked this pull request as ready for review September 19, 2023 14:25
@spencer-tb spencer-tb force-pushed the beacon-root-predeploy-address-update branch from 8ad7f7e to b61f6bd Compare September 19, 2023 14:26
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

If we change the address again, I guess we can make another PR 🙃

@marioevz marioevz changed the title tests/cancun/eip_4788: Update predeploy address & add additional tests tests/cancun/eip_4788: Update predeploy address(0xbEAC02..7d7a), add additional tests Sep 19, 2023
@marioevz marioevz merged commit 805980d into ethereum:main Sep 19, 2023
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
…additional tests (ethereum#297)

* tests/cancun/eip_4788: Update naming to match spec.

* tests/cancun/eip_4788: Update history buffer length.

* tests/cancun/eip_4788: Add todo for remaining values to update.

* tests/cancun/eip_4788: Add test for zero calldata value.

* forks: Latest Beacon Root Update to 0xBEA...BCA

* tests/cancun: Latest Beacon Root Update to 0xBEA...BCA

* refactor: wrap specification params in a Spec class

* tests/cancun/eip_4788|src/forks: final beacon root address update.

* tests/cancun/eip_4788: add small self-destruct test.

* tests/cancun/eip-4788: deployer address in spec

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants