✨ feat(tests): EIP-7928 net zero balance transactions#2280
Conversation
|
Hey @raxhvl I added a changelog entry and I changed the test up a bit. I'd like to record net-zero transfers even when the starting balance is non-zero. Please take a look at the change here and let me know if you are good with it or let me know your thoughts. We also record the balance of the contract along the way so this can be captured as a sanity check. I think this is good to go from my end but will wait for your feedback here before we merge. |
|
This looks much better, thanks! One concern for the 0->0 net transfer can we still include the |
We cover this in the self destruct test |
Ah no it's quite different. The self destruct has no balance change. Yeah, let's add this as a self destruct test variation of the 0 -> 0 case. Can you add this here? |
|
I have added the |
* ✨ feat(tests): test_bal_net_zero_balance_transfer * refactor: net-zero balance transfer tests w/ differing starting balances * chore: add changelog entry for ethereum#2280 * ✨ feat(tests): test_bal_net_zero_balance_transfer --------- Co-authored-by: raxhvl <raxhvl@users.noreply.github.com> Co-authored-by: fselmo <fselmo2@gmail.com>
🗒️ Description
Adds the net zero balance transaction as discussed in this PR to the spec.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.