Skip to content

chore(consume): add retries for connection refused from post requests #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spencer-tb wants to merge 1 commit into from
Closed

chore(consume): add retries for connection refused from post requests #2195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/ethereum_test_rpc/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,24 @@ def post_request(
}
headers = base_header | extra_headers

logger.debug(f"Sending RPC request, timeout is set to {timeout}...")
response = requests.post(self.url, json=payload, headers=headers, timeout=timeout)
response.raise_for_status()
response_json = response.json()

if "error" in response_json:
raise JSONRPCError(**response_json["error"])

assert "result" in response_json, "RPC response didn't contain a result field"
result = response_json["result"]
return result
for attempt in range(6):
try:
logger.debug(f"Sending RPC request, timeout is set to {timeout}...")
response = requests.post(self.url, json=payload, headers=headers, timeout=timeout)
response.raise_for_status()
response_json = response.json()
if "error" in response_json:
raise JSONRPCError(**response_json["error"])

assert "result" in response_json, "RPC response didn't contain a result field"
result = response_json["result"]
return result
except requests.ConnectionError as e:
if ("Connection refused" in str(e) or "Errno 111" in str(e)) and attempt < 4:
Copy link
Member

@danceratopz danceratopz Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has an off by one:

Suggested change
if ("Connection refused" in str(e) or "Errno 111" in str(e)) and attempt < 4:
if ("Connection refused" in str(e) or "Errno 111" in str(e)) and attempt < 5:

if attempt > 0:
time.sleep(1.0)
continue
raise


class EthRPC(BaseRPC):
Expand Down
Loading