Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Sep 15, 2025

πŸ—’οΈ Description

Add invalid precompile input cases for p256verify precompile, it is one of the Nethermind gas-benchmarks cases.

πŸ”— Related Issues or PRs

Issue #2026

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Sep 15, 2025
@LouisTsai-Csie LouisTsai-Csie added feature:benchmark fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` labels Sep 15, 2025
@LouisTsai-Csie
Copy link
Collaborator Author

A low hanging fruit for us to close issue #2026

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I left a comment about making the strings available via the spec file, but feel free to take or leave it :)

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@spencer-tb spencer-tb merged commit 952fe68 into ethereum:main Sep 16, 2025
16 checks passed
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:benchmark fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants