fix(tests): Restrict extra args being passed to BaseTest; fix valid BAL tests#2102
Merged
marioevz merged 2 commits intoethereum:mainfrom Sep 4, 2025
Merged
Conversation
fselmo
added
type:bug
- refactor(tests): Remove benign extra args to blockchain tests After restricting extra args, some tests were failing because they passed extra args that do not exist on the `BlockchainTest` class. This does not affect the test itself but now will cause failure. Thankfully, mypy caught all of these so it was easier to identify.
- BAL tests were wrongly passing the expected BAL to the ``blockchain_test`` itself. This was updated to live on the ``Block`` itself, but the tests were not updated. With the recent changes to restrict extra fields on the ``BlockchainTest`` (``BaseTest`` classess), this now correctly raises an error and allows us to have a sanity check.
fselmo
force-pushed
the
fix/bal-tests-and-test-constraints
branch
from
accfedd to
b2fb124
Compare
marioevz
approved these changes
Sep 4, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM! I don't know how we survived this long without this, but better late than never, tysm!
LouisTsai-Csie
pushed a commit
to LouisTsai-Csie/execution-spec-tests
that referenced
this pull request
Sep 5, 2025
… BAL tests (ethereum#2102) * - fix(fw): Restrict extra fields for ``BaseTest`` types - refactor(tests): Remove benign extra args to blockchain tests After restricting extra args, some tests were failing because they passed extra args that do not exist on the `BlockchainTest` class. This does not affect the test itself but now will cause failure. Thankfully, mypy caught all of these so it was easier to identify. * fix(tests,bal): Fix unreleased BAL tests from old design - BAL tests were wrongly passing the expected BAL to the ``blockchain_test`` itself. This was updated to live on the ``Block`` itself, but the tests were not updated. With the recent changes to restrict extra fields on the ``BlockchainTest`` (``BaseTest`` classess), this now correctly raises an error and allows us to have a sanity check.
5 tasks
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
… BAL tests (ethereum#2102) * - fix(fw): Restrict extra fields for ``BaseTest`` types - refactor(tests): Remove benign extra args to blockchain tests After restricting extra args, some tests were failing because they passed extra args that do not exist on the `BlockchainTest` class. This does not affect the test itself but now will cause failure. Thankfully, mypy caught all of these so it was easier to identify. * fix(tests,bal): Fix unreleased BAL tests from old design - BAL tests were wrongly passing the expected BAL to the ``blockchain_test`` itself. This was updated to live on the ``Block`` itself, but the tests were not updated. With the recent changes to restrict extra fields on the ``BlockchainTest`` (``BaseTest`` classess), this now correctly raises an error and allows us to have a sanity check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
BaseTestimplementationmypywithout needing to run all the tests 👌🏼Block, not on theBlockchainTestclass🔗 Related Issues or PRs
#2067
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.