src(partial blob response): Framework changes and test added for unavailable blob situations#2072
Conversation
|
Have not reviewed yet, but |
marioevz
left a comment
There was a problem hiding this comment.
Looks really good! Only a couple of comments, and I will try to fix the execute-fill-forks plugin issues in a separate PR today so we don't encounter issues that require modifying the resolver like the one here in the future.
aa31d0c to
8a14e34
Compare
Edit: fixed |
marioevz
left a comment
There was a problem hiding this comment.
Just a couple of comments, and the branch needs a simple rebase to main, but should be ready.
0a7ae20 to
6ad89a0
Compare
|
Applied your proposed changes and rebased on main |
marioevz
left a comment
There was a problem hiding this comment.
Awesome work, thanks for this!
…ailable blob situations (ethereum#2072) * wip * fix(plugins/forks): Remove evm_bin usage from forks plugin * cherry-picked mario pr for removing evm-bin dependency * mario feedback --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
🗒️ Description
This is a prototype, lmk what you think. I couldn't locally test these changes without changed the spec-evm-resolver version, but maybe it works without somehow. I locally test this running
go run . --docker.buildoutput --client=go-ethereum --client-file=clients_pectra.yaml --dev --loglevel=5and
uv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs --fork=osaka -vv -s(this still works) oruv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs_nonexisting --fork=osaka -vv -s(wip)🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.