feat(tests): enhance eip7825 test coverage for checklist #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisTsai-Csie
added
fork:osaka
LouisTsai-Csie
commented
Aug 13, 2025
LouisTsai-Csie
commented
Aug 13, 2025
marioevz
reviewed
Aug 21, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Amazing additions, I added comments that could be simply committed as-is and should not break anything.
However I didn't add comments to test_tx_gas_limit_cap_contract_creation, test_tx_gas_limit_cap_access_list_with_diff_keys, test_tx_gas_limit_cap_access_list_with_diff_addr, nor test_tx_gas_limit_cap_authorized_tx, but the same comments to test_tx_gas_limit_cap_full_calldata apply to these tests too!
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
LouisTsai-Csie
force-pushed
the
enhance-eip7825-coverage
branch
from
5b222b0 to
7ec7c1a
Compare
LouisTsai-Csie
commented
Aug 22, 2025
marioevz
approved these changes
Aug 22, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Amazing additions, thanks so much for implementing these, let's get them in the next release.
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* refactor(eip7825): update legacy configuration * tests(eip7825): add extra cases for tx gas limit * test(eip7825): add extra case for access list * refactor: update test logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Enhance test coverage for eip-7825 checklist, all the testing scenario can be found in issue ethereum/execution-specs#1565.
🔗 Related Issues or PRs
Issue ethereum/execution-specs#1565
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.